New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fork the goja project #3772

Closed

sniku opened this issue Jun 5, 2024 · 0 comments

Assignees

Labels

breaking change feature

Collaborator

sniku commented Jun 5, 2024

Feature Description

Create a fork of the goja project under the Grafana GitHub organization to accelerate the development speed and unblock the ESM work.

Goja, the JS runtime is the biggest k6 dependency. While the project is stable and mostly feature-complete, it has only one time-constrained maintainer. As goja is the cornerstone of k6, and a dependency of hundreds of xk6 extensions, the k6 core team needs an ability to develop changes at a higher speed than is possible today.

This is especially important now that we are preparing for the v1.0.0 stable release.

The fork will unblock merging of the Modules support PR, the possible future work on a debugger, and other changes.
We should do our best not to diverge from master/goja more than necessary. We should upstream enhancements whenever possible and work with @dop251, the maintainer, to keep the project in a healthy state.

Suggested Solution (optional)

No response

Already existing or connected issues / PRs (optional)

No response

sniku added the feature label

github-actions bot added the triage label

github-actions bot assigned mstoykov

mstoykov mentioned this issue

Moving to a goja fork #3773

Closed

mstoykov added breaking change and removed triage labels

mstoykov added a commit that referenced this issue


          Switch to our fork of goja - sodek

391957e

This is part of #3772 and #3773.

Moving to the currently only aliases codebase lets us update dependent
modules such as extension one at a time.

mstoykov mentioned this issue

Switch to our fork of goja - sobek #3775

Merged

5 tasks

mstoykov added a commit that referenced this issue


          Switch to our fork of goja - sobek

db3fb66

This is part of #3772 and #3773.

Moving to the currently only aliases codebase lets us update dependent
modules such as extension one at a time.

mstoykov added a commit that referenced this issue


          Switch to our fork of goja - sobek

bd114fd

This is part of #3772 and #3773.

Moving to the currently only aliases codebase lets us update dependent
modules such as extension one at a time.

mstoykov added a commit to grafana/xk6-browser that referenced this issue


          Change to using serbo instead of goja

2d8a5af

We are moving to a fork of goja under grafana org called serbo.

More info in:
- grafana/k6#3772
- grafana/k6#3773

mstoykov mentioned this issue

Change to using sobek instead of goja grafana/xk6-browser#1372

Closed

mstoykov added a commit to grafana/xk6-dashboard that referenced this issue


          Change to using serbo instead of goja

833bcc1

We are moving to a fork of goja under grafana org called serbo.

More info in:
- grafana/k6#3772
- grafana/k6#3773

mstoykov mentioned this issue

Change to using sobek instead of goja grafana/xk6-dashboard#189

Merged

mstoykov added a commit to grafana/xk6-output-prometheus-remote that referenced this issue


          Change to using serbo instead of goja

3ba7883

We are moving to a fork of goja under grafana org called serbo.

More info in:
- grafana/k6#3772
- grafana/k6#3773

mstoykov mentioned this issue

Change to using sobek instead of goja grafana/xk6-output-prometheus-remote#167

Merged

mstoykov added a commit to grafana/xk6-redis that referenced this issue


          Change to using serbo instead of goja

We are moving to a fork of goja under grafana org called serbo.

More info in:
- grafana/k6#3772
- grafana/k6#3773

mstoykov mentioned this issue

Change to using sobek instead of goja grafana/xk6-redis#33

Merged

mstoykov added a commit to grafana/xk6-webcrypto that referenced this issue


          Change to using serbo instead of goja

6024bf0

We are moving to a fork of goja under grafana org called serbo.

More info in:
- grafana/k6#3772
- grafana/k6#3773

mstoykov mentioned this issue

Change to using sobek instead of goja grafana/xk6-webcrypto#82

Merged

mstoykov added a commit to grafana/xk6-websockets that referenced this issue


          Change to using serbo instead of goja

0f173d0

We are moving to a fork of goja under grafana org called serbo.

More info in:
- grafana/k6#3772
- grafana/k6#3773

mstoykov mentioned this issue

Change to using sobek instead of goja grafana/xk6-websockets#72

Merged

mstoykov added a commit to grafana/xk6-webcrypto that referenced this issue


          Change to using serbo instead of goja

ecfe638

We are moving to a fork of goja under grafana org called serbo.

More info in:
- grafana/k6#3772
- grafana/k6#3773

mstoykov added a commit to grafana/xk6-websockets that referenced this issue


          Change to using serbo instead of goja

939f18c

We are moving to a fork of goja under grafana org called serbo.

More info in:
- grafana/k6#3772
- grafana/k6#3773

mstoykov added a commit to grafana/xk6-redis that referenced this issue


          Change to using sobek instead of goja

668515a

We are moving to a fork of goja under grafana org called sobek.

More info in:
- grafana/k6#3772
- grafana/k6#3773

mstoykov added a commit to grafana/xk6-webcrypto that referenced this issue


          Change to using sobek instead of goja

49b45d3

We are moving to a fork of goja under grafana org called sobek.

More info in:
- grafana/k6#3772
- grafana/k6#3773

mstoykov added a commit to grafana/xk6-websockets that referenced this issue


          Change to using sobek instead of goja

3873d68

We are moving to a fork of goja under grafana org called sobek.

More info in:
- grafana/k6#3772
- grafana/k6#3773

mstoykov added a commit to grafana/xk6-redis that referenced this issue


          Change to using sobek instead of goja

a296c20

We are moving to a fork of goja under grafana org called sobek.

More info in:
- grafana/k6#3772
- grafana/k6#3773

mstoykov added a commit to grafana/xk6-webcrypto that referenced this issue


          Change to using sobek instead of goja

f1540c6

We are moving to a fork of goja under grafana org called sobek.

More info in:
- grafana/k6#3772
- grafana/k6#3773

mstoykov added a commit to grafana/xk6-websockets that referenced this issue


          Change to using sobek instead of goja

7a69bb6

We are moving to a fork of goja under grafana org called sobek.

More info in:
- grafana/k6#3772
- grafana/k6#3773

This was referenced Jun 10, 2024

Change to using sobek instead of goja kelseyaubrecht/xk6-webtransport#6

Merged

Change to using sobek instead of goja domsolutions/xk6-fasthttp#20

Merged

Change to using sobek instead of goja mcosta74/xk6-plist#1

Merged

Change to using sobek instead of goja akiomik/xk6-nostr#1

Closed

mostafa pushed a commit to mostafa/xk6-kafka that referenced this issue


          Change to using sobek instead of goja (#297)

3ea6bfe

We are moving to a fork of goja under grafana org called sobek.

More info in:
- grafana/k6#3772
- grafana/k6#3773

acuenca-facephi pushed a commit to acuenca-facephi/xk6-read that referenced this issue


          Change to using sobek instead of goja (#2)

We are moving to a fork of goja under grafana org called sobek.

More info in:
- grafana/k6#3772
- grafana/k6#3773

mstoykov added a commit to grafana/sobek that referenced this issue


          Rename to sobek

2877de0

See grafana/k6#3772

mstoykov added a commit to grafana/sobek that referenced this issue


          Rename to sobek

b20e1ef

See grafana/k6#3772

nicholasvuono pushed a commit to nicholasvuono/xk6-playwright that referenced this issue


          Change to using sobek instead of goja (#15)

b941053

We are moving to a fork of goja under grafana org called sobek.

More info in:
- grafana/k6#3772
- grafana/k6#3773

JorTurFer pushed a commit to JorTurFer/xk6-input-prometheus that referenced this issue


          Change to using sobek instead of goja (#1)

a49f8f3

We are moving to a fork of goja under grafana org called sobek.

More info in:
- grafana/k6#3772
- grafana/k6#3773

mstoykov added a commit to grafana/sobek that referenced this issue


          Rename to sobek

660443b

See grafana/k6#3772

Apart from renaming:
1. Drop the goja package as it depends on goja_nodejs and we are not
   forking this ... yet.
2. Drop references to goja_nodejs for the same reason.
3. Point out this is a fork of goja.

Some links to goja are left as they link to issues that are still
relevant for the point being made.

mstoykov added a commit to grafana/sobek that referenced this issue


          Rename to sobek

1a77bda

See grafana/k6#3772

Apart from renaming:
1. Drop the goja package as it depends on goja_nodejs and we are not
   forking this ... yet.
2. Drop references to goja_nodejs for the same reason.
3. Point out this is a fork of goja.

Some links to goja are left as they link to issues that are still
relevant for the point being made.

mstoykov added a commit that referenced this issue


          Move to the forked sobek code

88a967d

There are still some leftover comments and names referencing goja that
need to be updated, but this compiles.

This closes #3772 and closes #3773

mstoykov mentioned this issue

Move to the forked Sobek code #3792

Merged

5 tasks

leonyork pushed a commit to leonyork/xk6-output-timestream that referenced this issue


          Change to using sobek instead of goja

1d9d040

We are moving to a fork of goja under grafana org called sobek.

More info in:
- grafana/k6#3772
- grafana/k6#3773

mstoykov added a commit to grafana/xk6-output-influxdb that referenced this issue


          Change to using sobek instead of goja

694d31b

We are moving to a fork of goja under grafana org called sobek.

More info in:
- grafana/k6#3772
- grafana/k6#3773

jt-shippit pushed a commit to jt-shippit/xk6-sql that referenced this issue


          Change to using sobek instead of goja

4628edc

We are moving to a fork of goja under grafana org called sobek.

More info in:
- grafana/k6#3772
- grafana/k6#3773

mstoykov added a commit to grafana/xk6-loki that referenced this issue


          Change to using sobek instead of goja (#67)

5248b47

We are moving to a fork of goja under grafana org called sobek.

More info in:
- grafana/k6#3772
- grafana/k6#3773

mstoykov added a commit to grafana/xk6-client-prometheus-remote that referenced this issue


          Change to using sobek instead of goja

d37919f

We are moving to a fork of goja under grafana org called sobek.

More info in:
- grafana/k6#3772
- grafana/k6#3773

mstoykov added a commit that referenced this issue


          Move to the forked sobek code

There are still some leftover comments and names referencing goja that
need to be updated, but this compiles.

This closes #3772 and closes #3773

skryukov pushed a commit to anycable/xk6-cable that referenced this issue


          Change to using sobek instead of goja

3c316ae

We are moving to a fork of goja under grafana org called sobek.

More info in:
- grafana/k6#3772
- grafana/k6#3773

BrewTestBot mentioned this issue

k6 0.52.0 Homebrew/homebrew-core#175582

Merged

mstoykov added a commit that referenced this issue


          Move to the forked Sobek code

ccdf673

There are still some leftover comments and names referencing goja that
need to be updated, but this compiles.

This closes #3772 and closes #3773

thmshmm pushed a commit to thmshmm/xk6-opentelemetry that referenced this issue


          Change to using sobek instead of goja

5694b64

We are moving to a fork of goja under grafana org called sobek.

More info in:
- grafana/k6#3772
- grafana/k6#3773

mstoykov closed this as completed in

278dbdc

pmalhaire pushed a commit to pmalhaire/xk6-mqtt that referenced this issue


          Change to using sobek instead of goja

54b2270

We are moving to a fork of goja under grafana org called sobek.

More info in:
- grafana/k6#3772
- grafana/k6#3773

nate20i mentioned this issue

Change to using sobek instead of goja nate20i/xk6-cognito#2

Merged

mstoykov mentioned this issue

Modules support dop251/goja#430

Open

pablochacin pushed a commit to grafana/xk6-disruptor that referenced this issue


          Change to using sobek instead of goja (#400)

f5d9d1e

We are moving to a fork of goja under grafana org called sobek.

More info in:
- grafana/k6#3772
- grafana/k6#3773

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment