Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dispose context canceled errors #1261

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Fix dispose context canceled errors #1261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion common/js_handle.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package common

import (
"context"
"errors"
"fmt"

"github.com/grafana/xk6-browser/k6ext"
Expand Down Expand Up @@ -79,7 +80,13 @@ func (h *BaseJSHandle) AsElement() *ElementHandle {
// Dispose releases the remote object.
func (h *BaseJSHandle) Dispose() {
if err := h.dispose(); err != nil {
k6ext.Panic(h.ctx, "dispose: %w", err)
// We do not want to panic on an error when the error is a closed
// context. The reason the context would be closed is due to the
// iteration ending and therefore the associated browser and its assets
// will be automatically deleted.
if !errors.Is(err, context.Canceled) {
k6ext.Panic(h.ctx, "dispose: %w", err)
}
}
}

Expand Down
Loading