Fix dispose context canceled errors #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankur22
force-pushed
the
fix/exec-context-session
branch
from
b398508 to
3405f11
Compare
ankur22
force-pushed
the
investigate/dispose-constext-canceled
branch
from
beba74e to
e8440a0
Compare
inancgumus
reviewed
Apr 15, 2024
ankur22
force-pushed
the
fix/exec-context-session
branch
from
3405f11 to
a752709
Compare
ankur22
force-pushed
the
investigate/dispose-constext-canceled
branch
from
e8440a0 to
f2817ff
Compare
ankur22
force-pushed
the
investigate/dispose-constext-canceled
branch
from
f2817ff to
4ad0c4d
Compare
ankur22
force-pushed
the
investigate/dispose-constext-canceled
branch
from
4ad0c4d to
72e66c3
Compare
ankur22
changed the title
inancgumus
approved these changes
Apr 23, 2024
If the context is closed, and that is the error that is received by the dispose method, then that would elude to the fact that the iteration has ended. Therefore, we shouldn't need to panic or log an error at this point, and instead just continue on as normal. The page has closed well before this panic occurs.
ankur22
force-pushed
the
investigate/dispose-constext-canceled
branch
from
72e66c3 to
483952a
Compare
This was referenced Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Ignore context canceled errors when attempting to dispose of a
frame.Why?
When testing websites which contain
iframes, they can cause apanic: GoError: dispose: canceledpanic. This is confusing behaviour since after investigating the issue it turns out that the dispose doesn't need to occur since thepagetheiframeis associated to is already closed. More details can be found in this comment.It's worth noting that this is more of a work around. A better solution might be to not end the iteration until all the CDP messages between k6 and Chrome ended successfully, but this would require quite a bit of refactoring and possibly more control over the iteration.
Checklist
Related PR(s)/Issue(s)
#1089