Remove the timeout option from isVisible and isHidden #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the need to pass in a 0 value for the timeout from frame and elementHandle. The reason for removing the timeout is that isVisible doesn't wait on an element, so there is no need for a timeout.
This removes the need to pass in a 0 value for the timeout from frame and elementHandle. The reason for removing the timeout is that isHidden doesn't wait on an element, so there is no need for a timeout.
The timeout is no longer used since isVisible now returns straight away without waiting for an element to match if one doesn't already exist.
It did accepts options which were strict and timeout. Strict is enabled and cannot be changed when working with the locator API. Timeout is no longer useful when working with isVisible.
The timeout is no longer used since isHidden now returns straight away without waiting for an element to match if one doesn't already exist.
It did accepts options which were strict and timeout. Strict is enabled and cannot be changed when working with the locator API. Timeout is no longer useful when working with isHidden.
ankur22
force-pushed
the
breaking/timeout
branch
from
bb54892 to
5928ccd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This remove the
timeoutoption fromisVisibleandisHiddenwhich are part ofelementHandle,frame,pageandlocatorAPIs.Why?
isVisibleandisHiddenno longer wait for an element match for the given selector, and so it doesn't make sense to parse and try to work with a timeout parameter.Checklist
Related PR(s)/Issue(s)
Updates: #981