Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor isHidden to return an error #1109

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Refactor isHidden to return an error #1109

merged 2 commits into from
Nov 23, 2023

Conversation

ankur22
Copy link
Collaborator

@ankur22 ankur22 commented Nov 22, 2023 •
edited
Loading

What?

This refactors isHidden for locator, page, frame and elementHandle.

Why?

Returning an error is a safer way to work instead pf performing a panic which could have unexpected consequences.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

Updates: #688
Updates: #981

@ankur22 ankur22 requested review from inancgumus and ka3de November 22, 2023 16:34
@ankur22 ankur22 changed the base branch from main to fix/isVisible November 22, 2023 17:00
@ankur22 ankur22 mentioned this pull request Nov 22, 2023
Closed
inancgumus
inancgumus approved these changes Nov 23, 2023
View reviewed changes
tests/locator_test.go Show resolved Hide resolved
@ankur22 ankur22 force-pushed the fix/isVisible branch 2 times, most recently from 9e1d3ed to b971314 Compare November 23, 2023 09:46
@ankur22 ankur22 force-pushed the fix/isVisible branch 2 times, most recently from be914dc to 317efca Compare November 23, 2023 10:44
Base automatically changed from fix/isVisible to main-next November 23, 2023 10:57
@ankur22 ankur22 merged commit a86503d into main-next Nov 23, 2023
14 checks passed
@ankur22 ankur22 deleted the fix/isHidden branch November 23, 2023 15:08
@BrewTestBot BrewTestBot mentioned this pull request Jan 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inancgumus inancgumus inancgumus approved these changes

@ka3de ka3de Awaiting requested review from ka3de

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ankur22 @inancgumus