Fix isVisible #1108
Merged
Fix isVisible #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankur22
force-pushed
the
fix/isVisible
branch
2 times, most recently
from
b0a3d61 to
c368543
Compare
inancgumus
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
👍 Some suggestions.
@ankur22 Does this conform to auto-waiting actionability checks? https://playwright.dev/docs/actionability
No, this isn't a prerequisite for the |
ankur22
force-pushed
the
fix/isVisible
branch
from
c368543 to
9e1d3ed
Compare
ankur22
force-pushed
the
refactor/query
branch
from
d7f3f53 to
a9cb198
Compare
ankur22
force-pushed
the
fix/isVisible
branch
from
9e1d3ed to
b971314
Compare
ankur22
force-pushed
the
fix/isVisible
branch
from
b971314 to
be914dc
Compare
This method is to be used when an API needs to: 1. query for a handler given a selector with or without strict mode enabled. 2. Perform an action on the handler if one was found, otherwise return false. 3. Not wait for the element that matches the given selector. This will make the timeout option obsolete on APIs that work with this.
isVisible is changed to work with the new runActionOnSelector method, which does not wait for any elements to match the given selector. It will just return false if there are no matching elements. This also means that timeout is an obsolete option, which means that the test in locator_test is not valid and has been removed.
ankur22
force-pushed
the
fix/isVisible
branch
from
be914dc to
317efca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This fixes
isVisibleso that it does not wait for an element to match with the given selector, and returns straight away. This makes thetimeoutoption obsolete.Why?
There are two reason to make this change:
Checklist
Related PR(s)/Issue(s)
Updates: #981