Add waitForNavigation error to span

grafana · Apr 22, 2024 · ecb98a9 · ecb98a9
1 parent 355e1b5
commit ecb98a9
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/common/page.go b/common/page.go
@@ -1335,7 +1335,13 @@ func (p *Page) WaitForNavigation(opts *FrameWaitForNavigationOptions) (*Response
 	_, span := TraceAPICall(p.ctx, p.targetID.String(), "page.waitForNavigation")
 	defer span.End()
 
-	return p.frameManager.MainFrame().WaitForNavigation(opts)
+	resp, err := p.frameManager.MainFrame().WaitForNavigation(opts)
+	if err != nil {
+		SpanRecordError(span, "waiting for navigation failed", err)
+		return nil, err
+	}
+
+	return resp, err
 }
 
 // WaitForRequest is not implemented.