Add screenshot error to span

grafana · Apr 22, 2024 · 355e1b5 · 355e1b5
1 parent 344f2f2
commit 355e1b5
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/common/page.go b/common/page.go
@@ -1147,7 +1147,9 @@ func (p *Page) Screenshot(opts *PageScreenshotOptions, sp ScreenshotPersister) (
 	s := newScreenshotter(spanCtx, sp)
 	buf, err := s.screenshotPage(p, opts)
 	if err != nil {
-		return nil, fmt.Errorf("taking screenshot of page: %w", err)
+		err = fmt.Errorf("taking screenshot of page: %w", err)
+		SpanRecordError(span, "screenshot failed", err)
+		return nil, err
 	}
 
 	return buf, err