Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Self-contained ML package #1397

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Self-contained ML package #1397

merged 1 commit into from
Mar 5, 2024

Conversation

julienduchesne
Copy link
Member

Just like #1393 and #1396

  • Makes the resource functions private (exposed via a single map attribute) rather than each resource individually
  • Puts the client validation in the ML package

@julienduchesne
Self-contained ML package
1c172eb 
Just like #1393 and #1396

- Makes the resource functions private (exposed via a single map attribute) rather than each resource individually
- Puts the client validation in the ML package
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2024

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

@julienduchesne julienduchesne marked this pull request as ready for review March 3, 2024 16:10
@julienduchesne julienduchesne requested review from a team as code owners March 3, 2024 16:10
sd2k
sd2k approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@sd2k sd2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me!

@julienduchesne julienduchesne merged commit 791c195 into main Mar 5, 2024
25 checks passed
@julienduchesne julienduchesne deleted the julienduchesne/self-contained-ml branch March 5, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sd2k sd2k sd2k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienduchesne @sd2k