Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-contained cloud package #1393

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

julienduchesne
Copy link
Member

Split from #1391

  • Makes the resource functions private (exposed via a single map attribute) rather than each resource individually
  • Puts the client validation in the cloud package

Copy link

github-actions bot commented Mar 2, 2024

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

Base automatically changed from julienduchesne/update-gcom-client to main March 2, 2024 13:36
@julienduchesne julienduchesne force-pushed the julienduchesne/cloud-private branch from 0b826cb to 9b26801 Compare March 2, 2024 13:37
@julienduchesne julienduchesne marked this pull request as ready for review March 2, 2024 13:47
@julienduchesne julienduchesne requested review from a team as code owners March 2, 2024 13:47
julienduchesne added a commit that referenced this pull request Mar 3, 2024
Just like #1393

- Makes the resource functions private (exposed via a single map attribute) rather than each resource individually
- Puts the client validation in the SLO package
julienduchesne added a commit that referenced this pull request Mar 3, 2024
Just like #1393 and #1396

- Makes the resource functions private (exposed via a single map attribute) rather than each resource individually
- Puts the client validation in the ML package
julienduchesne added a commit that referenced this pull request Mar 5, 2024
Just like #1393 and #1396

- Makes the resource functions private (exposed via a single map attribute) rather than each resource individually
- Puts the client validation in the ML package
Split from #1391
- Makes the resource functions private (exposed via a single map attribute) rather than each resource individually
- Puts the client validation in the cloud package
@julienduchesne julienduchesne force-pushed the julienduchesne/cloud-private branch from 9b26801 to b8b84d2 Compare March 5, 2024 13:36
@julienduchesne julienduchesne merged commit 2689148 into main Mar 5, 2024
25 checks passed
@julienduchesne julienduchesne deleted the julienduchesne/cloud-private branch March 5, 2024 13:46
julienduchesne added a commit that referenced this pull request Mar 5, 2024
* Self-contained SLO package
Just like #1393

- Makes the resource functions private (exposed via a single map attribute) rather than each resource individually
- Puts the client validation in the SLO package

* Format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants