Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(frontend): disables watch mode, improves error message #482

Merged
merged 2 commits into from
Oct 29, 2021

Conversation

petethepig
Copy link
Member

No description provided.

@petethepig petethepig requested a review from eh-am October 28, 2021 21:53
@github-actions github-actions bot requested a review from Rperry2174 October 28, 2021 21:53
@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 443.49 KB (0%) 8.9 s (0%) 278 ms (+14.7% 🔺) 9.2 s

@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #482 (866e0e1) into main (8653517) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #482   +/-   ##
=======================================
  Coverage   54.37%   54.37%           
=======================================
  Files         161      161           
  Lines        6751     6751           
  Branches      161      161           
=======================================
  Hits         3670     3670           
  Misses       2766     2766           
  Partials      315      315           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8653517...866e0e1. Read the comment docs.

@pyroscopebot
Copy link
Collaborator

pyroscopebot commented Oct 28, 2021

Parameters

Details
Name Value
BENCH_RUN_FOR 10m
PYROBENCH_RAND_SEED 2306912
PYROBENCH_PROFILE_WIDTH 20
PYROBENCH_PROFILE_DEPTH 20
PYROBENCH_PROFILE_SYMBOL_LENGTH 30
PYROBENCH_APPS 20
PYROBENCH_CLIENTS 20
PYROBENCH_REQUESTS 10000

Result

main pr diff threshold
throughput 144.30 144.19 -0.11 (-0.08%) 5%
total items processed 115506.00 115045.00 -461.00 (-0.40%) 5%
Details
Name Description Query for main Query for pr
throughput rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"}[5m]) rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}[5m])
total items processed pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"} pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}

Screenshots

Throughput Throughput
Disk Usage Disk Usage
Memory Memory
Upload Errors (Total) Upload Errors (Total)
Successful Uploads (Total) Successful Uploads (Total)
CPU Utilization CPU Utilization

Generated by 🚫 dangerJS against 3ca7916

@petethepig petethepig merged commit 67dc7f1 into main Oct 29, 2021
@petethepig petethepig deleted the assets-watch-mode branch October 29, 2021 01:38
korniltsev pushed a commit that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants