Skip to content

Commit

Permalink
build(frontend): disables watch mode, improves error message (#482)
Browse files Browse the repository at this point in the history
* disables watch mode, imporves error message

* fix for snapshot tests
  • Loading branch information
petethepig authored Oct 29, 2021
1 parent 8653517 commit 67dc7f1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/tests-js-snapshot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
# if you ever update this container
# remember to update the container that runs locally
# (ie ./scripts/jest-snapshots)
container: node:current-slim
container: node:14.15-slim
steps:
- name: Checkout
uses: actions/checkout@v2
Expand Down
3 changes: 1 addition & 2 deletions scripts/webpack/webpack.dev.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ const common = require('./webpack.common');
const sleep = (ms) => new Promise((res) => setTimeout(res, ms));

module.exports = merge(common, {
watch: true,
devtool: 'eval-source-map',
mode: 'development',
entry: {
Expand All @@ -27,7 +26,7 @@ module.exports = merge(common, {
do {
if (maxTries <= 0) {
throw new Error(
'Could not find pyroscope instance running on http://localhost:4040'
'Could not find pyroscope instance running on http://localhost:4040. Make sure you have pyroscope server running on port :4040 (run `make build server`)'
);
}
res = request('GET', 'http://localhost:4040');
Expand Down

0 comments on commit 67dc7f1

Please sign in to comment.