Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start using native histograms for cortex_request_duration_seconds #4987

Merged
merged 2 commits into from
May 12, 2023
Merged

Start using native histograms for cortex_request_duration_seconds #4987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d4de2c
Start using native histograms for cortex_request_duration_seconds
zenador May 12, 2023
c577368
Update CHANGELOG according to code review
zenador May 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
* `cortex_alertmanager_nflog_maintenance_errors_total`
* `cortex_alertmanager_silences_maintenance_total`
* `cortex_alertmanager_silences_maintenance_errors_total`
* [ENHANCEMENT] Add native histogram support for `cortex_request_duration_seconds` metric family. #4987
* [BUGFIX] Metadata API: Mimir will now return an empty object when no metadata is available, matching Prometheus. #4782
* [BUGFIX] Store-gateway: add collision detection on expanded postings and individual postings cache keys. #4770
* [BUGFIX] Ruler: Support the `type=alert|record` query parameter for the API endpoint `<prometheus-http-prefix>/api/v1/rules`. #4302
Expand Down
2 changes: 2 additions & 0 deletions pkg/mimir/mimir.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,8 @@ type Config struct {
func (c *Config) RegisterFlags(f *flag.FlagSet, logger log.Logger) {
c.ApplicationName = "Grafana Mimir"
c.Server.MetricsNamespace = "cortex"
// Enable native histograms for enabled scrapers with 10% bucket growth.
c.Server.MetricsNativeHistogramFactor = 1.1
c.Server.ExcludeRequestInLog = true
c.Server.DisableRequestSuccessLog = true

Expand Down