Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start using native histograms for cortex_request_duration_seconds #4987

Merged

Conversation

zenador
Copy link
Contributor

@zenador zenador commented May 12, 2023

What this PR does

Makes cortex_request_duration_seconds a native histogram.

Which issue(s) this PR fixes or relates to

Fixes #4175

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@zenador zenador requested a review from a team as a code owner May 12, 2023 06:26
@zenador zenador force-pushed the zenador/native-histograms-cortex_request_duration_seconds branch from 645e2bd to 7f80327 Compare May 12, 2023 06:27
@zenador zenador requested a review from krajorama May 12, 2023 06:27
CHANGELOG.md Outdated Show resolved Hide resolved
@zenador zenador force-pushed the zenador/native-histograms-cortex_request_duration_seconds branch from 83b6c58 to c577368 Compare May 12, 2023 09:38
Copy link
Contributor

@krajorama krajorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's test in dev environment to be sure

@krajorama
Copy link
Contributor

Tested.

@krajorama krajorama merged commit d0a93ab into main May 12, 2023
@krajorama krajorama deleted the zenador/native-histograms-cortex_request_duration_seconds branch May 12, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Start using native histograms for cortex_request_duration_seconds
2 participants