Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(go.mod): Remove unnecessary grpc contraints from weaveworks/common #8125

Merged

Conversation

kavirajk
Copy link
Contributor

@kavirajk kavirajk commented Jan 12, 2023

Signed-off-by: Kaviraj [email protected]

What this PR does / why we need it:

Not needed after weaveworks/common#254 and weaveworks/common#262

More rationale on the issue.

Which issue(s) this PR fixes:
Fixes #8085

Special notes for your reviewer:

Checklist

@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-target-branch/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

@kavirajk kavirajk marked this pull request as ready for review January 12, 2023 21:59
@kavirajk kavirajk requested a review from a team as a code owner January 12, 2023 21:59
@MasslessParticle MasslessParticle merged commit 0d1144c into main Jan 12, 2023
@MasslessParticle MasslessParticle deleted the kavirajk/remove-unwanted-grpc-dependency-version branch January 12, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unnecessary replace in go.mod for weaveworks/common
3 participants