Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unnecessary replace in go.mod for weaveworks/common #8085

Closed
ryepup opened this issue Jan 10, 2023 · 0 comments · Fixed by #8125
Closed

unnecessary replace in go.mod for weaveworks/common #8085

ryepup opened this issue Jan 10, 2023 · 0 comments · Fixed by #8125

Comments

@ryepup
Copy link

ryepup commented Jan 10, 2023

loki/go.mod

Line 325 in b3e038c

// grpc v1.46.0 removed "WithBalancerName()" API, still in use by weaveworks/commons.

This is no longer true; after weaveworks/common#254 and weaveworks/common#262, it supports grpc v1.47.0
@ryepup ryepup mentioned this issue Jan 10, 2023
Closed
kavirajk added a commit that referenced this issue Jan 12, 2023
@kavirajk
chore(go.mod): Remove unnecessary grpc contraints from `weaveworks/co…
2e6cde6 
…mmon`

Fixes: #8085

Signed-off-by: Kaviraj <[email protected]>
@kavirajk kavirajk mentioned this issue Jan 12, 2023
Merged
1 task
MasslessParticle pushed a commit that referenced this issue Jan 12, 2023
@kavirajk
chore(go.mod): Remove unnecessary grpc contraints from `weaveworks/co…
0d1144c 
…mmon` (#8125)

Not needed after weaveworks/common#254 and
weaveworks/common#262

More rationale on the issue.

Fixes #8085 

Signed-off-by: Kaviraj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(go.mod): Remove unnecessary grpc contraints from weaveworks/common grafana/loki
1 participant
@ryepup