Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallize label queries to both stores #5997

Merged

Conversation

simonswine
Copy link
Contributor

@simonswine simonswine commented Apr 22, 2022

What this PR does / why we need it:

This executes label queries against ingesters and store in parallel, rather than sequentially.

Checklist
- [ ] Documentation added

  • Tests updated
  • Add an entry in the CHANGELOG.md about the changes.

@simonswine simonswine force-pushed the 20220422_parallel-store-ingester-queries branch from 53d45be to 8914b18 Compare April 22, 2022 16:38
@simonswine simonswine marked this pull request as ready for review April 22, 2022 16:40
@simonswine simonswine requested a review from a team as a code owner April 22, 2022 16:40
Copy link
Collaborator

@trevorwhitney trevorwhitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small nit

pkg/querier/querier.go Outdated Show resolved Hide resolved
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@trevorwhitney trevorwhitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for that change, let's get this merged!

@cyriltovena cyriltovena enabled auto-merge (squash) May 2, 2022 08:14
@stale
Copy link

stale bot commented Jun 12, 2022

Hi! This issue has been automatically marked as stale because it has not had any
activity in the past 30 days.

We use a stalebot among other tools to help manage the state of issues in this project.
A stalebot can be very useful in closing issues in a number of cases; the most common
is closing issues or PRs where the original reporter has not responded.

Stalebots are also emotionless and cruel and can close issues which are still very relevant.

If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry.

We regularly sort for closed issues which have a stale label sorted by thumbs up.

We may also:

  • Mark issues as revivable if we think it's a valid issue but isn't something we are likely
    to prioritize in the future (the issue will still remain closed).
  • Add a keepalive label to silence the stalebot if the issue is very common/popular/important.

We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task,
our sincere apologies if you find yourself at the mercy of the stalebot.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Jun 12, 2022
@simonswine simonswine force-pushed the 20220422_parallel-store-ingester-queries branch from 965fec7 to 75e4edf Compare June 16, 2022 14:33
This executes label queries against ingesters and store in parallel,
rather than sequentially
@simonswine simonswine force-pushed the 20220422_parallel-store-ingester-queries branch from 75e4edf to 7b44c17 Compare June 16, 2022 14:34
@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0.3%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

@cyriltovena cyriltovena merged commit 9ff6218 into grafana:main Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M stale A stale issue or PR that will automatically be closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants