Return err without any checks as suggested

grafana · Jun 16, 2022 · 7b44c17 · 7b44c17
1 parent 1becc2f
commit 7b44c17
Showing 1 changed file with 6 additions and 11 deletions.
diff --git a/pkg/querier/querier.go b/pkg/querier/querier.go
@@ -378,23 +378,18 @@ func (q *SingleTenantQuerier) Label(ctx context.Context, req *logproto.LabelRequ
 	var storeValues []string
 	if !q.cfg.QueryIngesterOnly && storeQueryInterval != nil {
 		g.Go(func() error {
-			var err error
-			from := model.TimeFromUnixNano(storeQueryInterval.start.UnixNano())
-			through := model.TimeFromUnixNano(storeQueryInterval.end.UnixNano())
+			var (
+				err     error
+				from    = model.TimeFromUnixNano(storeQueryInterval.start.UnixNano())
+				through = model.TimeFromUnixNano(storeQueryInterval.end.UnixNano())
+			)
 
 			if req.Values {
 				storeValues, err = q.store.LabelValuesForMetricName(ctx, userID, from, through, "logs", req.Name)
-				if err != nil {
-					return err
-				}
 			} else {
 				storeValues, err = q.store.LabelNamesForMetricName(ctx, userID, from, through, "logs")
-				if err != nil {
-					return err
-				}
 			}
-
-			return nil
+			return err
 		})
 	}