Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow ingester and distributor to run on same instance #4348

Merged
merged 3 commits into from
Sep 17, 2021
Merged

allow ingester and distributor to run on same instance #4348

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e08351d
allow ingester and distributor to run on same instance
trevorwhitney Sep 17, 2021
3b93a60
add comment around conditional distributor Push registration
trevorwhitney Sep 17, 2021
1cdda0c
lint
slim-bean Sep 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/loki/modules.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,9 @@ func (t *Loki) initDistributor() (services.Service, error) {
return nil, err
}

if !t.Cfg.isModuleEnabled(All) {
// Register the distributor to receive Push requests over GRPC
// EXCEPT when running with `-target=all` or `-target=` contains `ingester`
if !t.Cfg.isModuleEnabled(All) && !t.Cfg.isModuleEnabled(Ingester) {
trevorwhitney marked this conversation as resolved.
Show resolved Hide resolved
logproto.RegisterPusherServer(t.Server.GRPC, t.distributor)
}

Expand Down