allow ingester and distributor to run on same instance #4348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Trevor Whitney <[email protected]>
slim-bean
reviewed
Sep 17, 2021
Co-authored-by: Ed Welch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Trevor Whitney [email protected]
What this PR does / why we need it:
When running loki with target
--target=distributor,ingesterit fails with the errorFATAL: 2021/09/17 18:48:10 [core] grpc: Server.RegisterService found duplicate service registration for "logproto.Pusher". This is because the guard against registering the Pusher service in theinitDistributorcode is currently only guarding against theAlltarget. With our work on the "single scalable deployment", we plan on having a write path where both the distributor and ingester are enabled. This PR allows both targets to be enabled.Checklist