Perform token validation as part of 'k6 cloud login' #3930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanlopez
requested review from
mstoykov,
olegbespalov and
oleiade
and removed request for
a team
joanlopez
commented
Sep 4, 2024
| @@ -90,6 +104,9 @@ func (c *cmdCloudLogin) run(cmd *cobra.Command, _ []string) error { | |||
| newCloudConf.Token = null.StringFromPtr(nil) | |||
| printToStdout(c.globalState, " token reset\n") | |||
| case show.Bool: | |||
| valueColor := getColor(c.globalState.Flags.NoColor || !c.globalState.Stdout.IsTTY, color.FgCyan) | |||
There was a problem hiding this comment.
I moved these lines here, from the bottom of the file, as I think it only makes sense to print the token when providing the -s flag, as also discussed at #3886.
Otherwise, it doesn't, because:
- When resetting, with
-r, there's no token. - When providing it with
-t, it's already there. - When using the form, we define it as a sensitive field (so it's not displayed while being written).
If we want to show it in the last scenario, I'd just switch the form input type to regular text, otherwise (as it was until now) it is a bit incoherent.
joanlopez
force-pushed
the
validate-token
branch
from
a7064cc to
2324996
Compare
mstoykov
reviewed
Sep 4, 2024
olegbespalov
reviewed
Sep 4, 2024
oleiade
previously approved these changes
Sep 5, 2024
joanlopez
force-pushed
the
validate-token
branch
from
632f80c to
b3778a3
Compare
joanlopez
force-pushed
the
validate-token
branch
from
b3778a3 to
cdbca39
Compare
olegbespalov
previously approved these changes
Sep 9, 2024
oleiade
previously approved these changes
Sep 9, 2024
mstoykov
previously approved these changes
Sep 9, 2024
joanlopez
dismissed stale reviews from mstoykov, oleiade, and olegbespalov
via
d6ce425
olegbespalov
approved these changes
Sep 9, 2024
mstoykov
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
It performs token validation after as part of
k6 cloud loginprocess.Why?
As discussed in #3886, it's nice to give immediate feedback to users when "logging-in", instead of waiting until they use any other cloud command.
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)