Drop support for log in with email & password in the new k6 cloud login
#3886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanlopez
requested review from
mstoykov and
codebien
and removed request for
a team
This was referenced Aug 5, 2024
joanlopez
force-pushed
the
cloud_subcommands-drop_stdcreds-2
branch
from
1ae078b to
d534235
Compare
codebien
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
I see some potential improvements we should make to polish a bit the UX. We can do that during the next cycle.
- Mask the token on
k6 cloud logincommand - Do not use the authenticate word as it might create wrong expectations
- A better message output for the reset command
- The login command's output
Token: Empty
token: <here the token>
I see why this is happening but we should maybe make it a bit more user-friendly.
The important part has been addressed. Thanks @joanlopez 🙇
Would you mind listing them, so we don't forget them, please? 🙇🏻 |
joanlopez
requested review from
olegbespalov and
oleiade
and removed request for
olegbespalov
mstoykov
changed the title
k6 cloud login
mstoykov
approved these changes
Aug 7, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #3835
What?
It drops the support for the interactive login with email and password from the recently introduced
k6 cloud loginsubcommand.Why?
Because that authentication mechanism is considered deprecated, and so we only leave the support for it through the deprecated
k6 login cloudsubcommand, but not in the newk6 cloud logincommand.Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)