Warn on mixing ESM and commonJS #3807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of testing for #3265 it was noticed this isn't uncommon. As there is no way for this to be supported and it will be against how the specification works we prefer to warn users on this at least for a little while.
mstoykov
requested review from
oleiade and
joanlopez
and removed request for
a team
oleiade
previously approved these changes
Jun 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3807 +/- ##
=========================================
Coverage ? 71.87%
=========================================
Files ? 291
Lines ? 21274
Branches ? 0
=========================================
Hits ? 15290
Misses ? 4920
Partials ? 1064
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Théo Crevon <[email protected]>
codebien
reviewed
Jun 24, 2024
Co-authored-by: Ivan <[email protected]>
codebien
approved these changes
Jun 24, 2024
joanlopez
approved these changes
Jun 25, 2024
mstoykov
added a commit
to mstoykov/postman-to-k6
that referenced
this pull request
Jun 27, 2024
It seems that at some point when this was written someone mixed ESM and CommonJS syntax. There is not good reason to do this, and it will soon not be supported - and arguably has never been, it just happened to work due to how ESM was supported in k6. See grafana/k6#3807 and linked issues/PRs
thim81
pushed a commit
to apideck-libraries/postman-to-k6
that referenced
this pull request
Jun 27, 2024
It seems that at some point when this was written someone mixed ESM and CommonJS syntax. There is not good reason to do this, and it will soon not be supported - and arguably has never been, it just happened to work due to how ESM was supported in k6. See grafana/k6#3807 and linked issues/PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
As part of testing for #3265 it was noticed this isn't uncommon.
Why?
As there is no way for this to be supported and it will be against how the specification works we prefer to warn users on this at least for a little while.
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)