Don't mix ESM and CommonJS in shim/dynamic.js

[mstoykov]

It seems that at some point when this was written someone mixed ESM and CommonJS syntax.

There is not good reason to do this, and it will soon not be supported - and arguably has never been, it just happened to work due to how ESM was supported in k6.

See grafana/k6#3807 and linked issues/PRs

[thim81]

hi @mstoykov

Thanks for providing this PR.
Good to know that K6 will report on the mixing of the ESM and CommonJS syntax.

I'll make some time to verify if there are other files mixing the syntax.

[mstoykov]

Hi @thim81 , (posting here to not spam new issues or dicussions)

It will be nice to release with the merged fix as this is a problem that will become an error in k6 v0.53.0, but works fine with all previous versions.

So when we release v0.53.0 - all scripts will start to error out. The v0.53.0 is planned for 12th of August, so releasing this earlier might help with people not hitting this problem, or having less of an issue with hitting it.

[thim81]

hi @mstoykov

We just released the v1.11.0.
Thanks for your time and assistance with making postman-to-k6 ready for k6 v0.53.0.