Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade xk6-dashboard to v0.7.4 (sobek) #3780

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Upgrade xk6-dashboard to v0.7.4 (sobek) #3780

merged 2 commits into from
Jun 7, 2024

Conversation

szkiba
Copy link
Contributor

@szkiba szkiba commented Jun 7, 2024

What?

Upgrade xk6-dashboard to v0.7.4

Why?

v0.7.4 release created to use sobek instead of goja.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

xk6-dashboard v0.7.4 release created to using sobek instead of goja.
@szkiba szkiba requested a review from a team as a code owner June 7, 2024 11:40
@szkiba szkiba requested review from mstoykov and joanlopez and removed request for a team June 7, 2024 11:40
mstoykov
mstoykov previously approved these changes Jun 7, 2024
joanlopez
joanlopez previously approved these changes Jun 7, 2024
@szkiba szkiba dismissed stale reviews from joanlopez and mstoykov via b0697dd June 7, 2024 11:44
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 67.50000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 71.87%. Comparing base (e5b00db) to head (188da55).
Report is 1 commits behind head on master.

Current head 188da55 differs from pull request most recent head b0697dd

Please upload reports for the commit b0697dd to get more accurate results.

Files Patch % Lines
js/modules/k6/experimental/streams/module.go 67.50% 9 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3780      +/-   ##
==========================================
+ Coverage   70.84%   71.87%   +1.03%     
==========================================
  Files         291      291              
  Lines       21222    21247      +25     
==========================================
+ Hits        15035    15272     +237     
+ Misses       5222     4913     -309     
- Partials      965     1062      +97     
Flag Coverage Δ
ubuntu 71.80% <67.50%> (+1.01%) ⬆️
windows 71.72% <67.50%> (+1.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szkiba szkiba requested a review from joanlopez June 7, 2024 12:34
@szkiba szkiba merged commit f677714 into master Jun 7, 2024
22 checks passed
@szkiba szkiba deleted the sobek-xk6-dashboard branch June 7, 2024 14:28
@joanlopez joanlopez added this to the v0.52.0 milestone Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants