Deprecate statsd output #3347
Merged
Deprecate statsd output #3347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates #2982
codebien
approved these changes
Sep 21, 2023
| @@ -30,7 +30,13 @@ func getAllOutputConstructors() (map[string]output.Constructor, error) { | |||
| return nil, errors.New("the kafka output was deprecated in k6 v0.32.0 and removed in k6 v0.34.0, " + | |||
| "please use the new xk6 kafka output extension instead - https://github.com/k6io/xk6-output-kafka") | |||
| }, | |||
| "statsd": statsd.New, | |||
| "statsd": func(params output.Params) (output.Output, error) { | |||
| params.Logger.Warn("The statsd output is deprecated, and will be removed in a future k6 version. " + | |||
There was a problem hiding this comment.
We probably should update the datadog case too since it recommends using this statsd 😅
There was a problem hiding this comment.
I thought about this but prefer to leave it for when we remove this - to update both to the extension. Or to be honest to just drop kafka and datadog as they have not been a thing for over 2 years at this point 😅
There was a problem hiding this comment.
👍 for dropping (but OK with doing this in a separate PR)
olegbespalov
approved these changes
Sep 21, 2023
This was referenced Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #2982
Changelog
breaking: Deprecate statsd output
Statsd output has not been maintained very actively by the k6 core team and due to it not being very standard that isn't very likely to change. As such it has been decided that it will be moved to an extension and given to an outside maintainer that can better work on it.
The new extension can be found at https://github.com/LeonAdato/xk6-output-statsd