Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warning for statsd output #1359

Merged
merged 7 commits into from
Oct 11, 2023
Merged

Conversation

heitortsergent
Copy link
Collaborator

@heitortsergent heitortsergent commented Oct 3, 2023

Related to grafana/k6#3347, closes #1354.

@heitortsergent
Copy link
Collaborator Author

@mstoykov I did a quick search on the docs for this, and it looks like the Amazon CloudWatch, Datadog, Netdata, and New Relic integration pages all had instructions that included the --out statsd command.

Should I update their instructions so it includes instructions for how to build k6 with the new statsd extension, similar to the Apache Kafka page?

@heitortsergent heitortsergent added this to the v0.47.0 milestone Oct 3, 2023
@heitortsergent heitortsergent added the Area: OSS Content Improvements or additions to community/oss documentation label Oct 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

There's a version of the docs published here:

https://mdr-ci.staging.k6.io/docs/refs/pull/1359/merge

It will be deleted automatically in 30 days.

@mstoykov
Copy link
Contributor

mstoykov commented Oct 4, 2023

Hi @heitortsergent, this is a good catch and yes - let's do that.

@heitortsergent heitortsergent self-assigned this Oct 4, 2023
@heitortsergent heitortsergent marked this pull request as ready for review October 4, 2023 18:55
@heitortsergent
Copy link
Collaborator Author

@mstoykov made some updates to all the pages that had the --out statsd output, let me know what you think. :)

@codebien codebien removed this from the v0.47.0 milestone Oct 10, 2023
@heitortsergent heitortsergent merged commit 9fefc0a into main Oct 11, 2023
4 checks passed
@heitortsergent heitortsergent deleted the statsd-deprecated branch October 11, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: OSS Content Improvements or additions to community/oss documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update statsd docs
3 participants