Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interfacebloat linter #3271

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Add interfacebloat linter #3271

merged 2 commits into from
Aug 16, 2023

Conversation

codebien
Copy link
Contributor

@codebien codebien commented Aug 14, 2023

What?

Added interfacebloat linter as it is the unique linter currently disabled that we may want to enable.

Related PR(s)/Issue(s)

Closes #2715

@codebien codebien self-assigned this Aug 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2023

Codecov Report

Merging #3271 (84c12e2) into master (8fa0e6b) will decrease coverage by 0.03%.
Report is 15 commits behind head on master.
The diff coverage is n/a.

❗ Current head 84c12e2 differs from pull request most recent head 02dd442. Consider uploading reports for the commit 02dd442 to get more accurate results

@@            Coverage Diff             @@
##           master    #3271      +/-   ##
==========================================
- Coverage   73.21%   73.19%   -0.03%     
==========================================
  Files         258      258              
  Lines       19884    19884              
==========================================
- Hits        14559    14555       -4     
- Misses       4402     4405       +3     
- Partials      923      924       +1     
Flag Coverage Δ
ubuntu 73.12% <ø> (-0.03%) ⬇️
windows 73.07% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
lib/consts/consts.go 78.57% <ø> (ø)
lib/executors.go 93.10% <ø> (ø)

... and 2 files with indirect coverage changes

lib/executors.go Outdated Show resolved Hide resolved
lib/runner.go Outdated Show resolved Hide resolved
@mstoykov mstoykov added this to the v0.47.0 milestone Aug 16, 2023
mstoykov
mstoykov previously approved these changes Aug 16, 2023
olegbespalov
olegbespalov previously approved these changes Aug 16, 2023
@codebien codebien dismissed stale reviews from olegbespalov and mstoykov via 3b1d3e5 August 16, 2023 08:11
@codebien codebien force-pushed the add-interfacebloat-linter branch from 02dd442 to 3b1d3e5 Compare August 16, 2023 08:11
mstoykov
mstoykov previously approved these changes Aug 16, 2023
@codebien
Copy link
Contributor Author

I've forgot to run it locally 🤦 Now, it passes.

@codebien codebien merged commit cef6e56 into master Aug 16, 2023
@codebien codebien deleted the add-interfacebloat-linter branch August 16, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable all golangci linters and then enable the ones we want
4 participants