Skip to content

Commit

Permalink
Merge 4c6c52e into cbd9e9a
Browse files Browse the repository at this point in the history
  • Loading branch information
codebien authored Aug 14, 2023
2 parents cbd9e9a + 4c6c52e commit 84c12e2
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 0 deletions.
1 change: 1 addition & 0 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ linters:
- govet
- importas
- ineffassign
- interfacebloat
- lll
- makezero
- misspell
Expand Down
3 changes: 3 additions & 0 deletions lib/executors.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ type ExecutionStep struct {
// TODO: make []ExecutionStep or []ExecutorConfig their own type?

// ExecutorConfig is an interface that should be implemented by all executor config types
//
// nolint: interfacebloat
// At the moment we don't plan to split it. If a need will be raised then we may re-evaluate it.
type ExecutorConfig interface {
Validate() []error

Expand Down
4 changes: 4 additions & 0 deletions lib/runner.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ type VUActivationParams struct {
//
// TODO: Rename this to something more obvious? This name made sense a very long
// time ago.
//
// nolint: interfacebloat
// We may evaluate in the future if we can move out some methods;
// but considering how central it is, it would require a huge effort.
type Runner interface {
// Creates an Archive of the runner. There should be a corresponding NewFromArchive() function
// that will restore the runner from the archive.
Expand Down

0 comments on commit 84c12e2

Please sign in to comment.