Ensure REST API server is shut down after test ends and check for goroutine leaks #2803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
na--
force-pushed
the
init-vus-with-context
branch
from
3c041d2
to
ff2a8e4
Compare
na--
force-pushed
the
check-for-goroutine-leaks
branch
from
5f953af
to
f523e37
Compare
Codecov Report
@@ Coverage Diff @@
## init-vus-with-context #2803 +/- ##
========================================================
Coverage ? 76.07%
========================================================
Files ? 213
Lines ? 16591
Branches ? 0
========================================================
Hits ? 12621
Misses ? 3197
Partials ? 773
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
na--
force-pushed
the
init-vus-with-context
branch
from
ff2a8e4
to
dbde3c5
Compare
na--
force-pushed
the
check-for-goroutine-leaks
branch
from
f523e37
to
1766cb7
Compare
na--
changed the title
na--
force-pushed
the
init-vus-with-context
branch
from
dbde3c5
to
ed39495
Compare
na--
force-pushed
the
check-for-goroutine-leaks
branch
from
1766cb7
to
2cb2c74
Compare
codebien
reviewed
Dec 20, 2022
Comment on lines
+63
to
+71
| defer func() { | ||
| // TODO: figure out why logrus' `Entry.WriterLevel` goroutine sticks | ||
| // around and remove this exception. | ||
| opt := goleak.IgnoreTopFunction("io.(*pipe).read") | ||
| if err := goleak.Find(opt); err != nil { | ||
| fmt.Println(err) //nolint:forbidigo | ||
| exitCode = 3 | ||
| } | ||
| }() |
There was a problem hiding this comment.
I help here, I will take a look into it.
There was a problem hiding this comment.
For future reference, this will be resolved in #2833, which I think we should keep as a separate PR, rather than trying to merge it in this series of other PRs?
na--
force-pushed
the
init-vus-with-context
branch
2 times, most recently
from
9c9e35f
to
a7ad53f
Compare
na--
force-pushed
the
check-for-goroutine-leaks
branch
from
2cb2c74
to
2a9644a
Compare
na--
force-pushed
the
check-for-goroutine-leaks
branch
from
2a9644a
to
eea76b1
Compare
mstoykov
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on #2800