Use non-zero exit codes for some aborted by Ctrl+C or REST API tests #2807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2807 +/- ##
=======================================
Coverage 76.06% 76.06%
=======================================
Files 213 213
Lines 16593 16593
=======================================
Hits 12622 12622
Misses 3197 3197
Partials 774 774
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
na--
added
ux
breaking change
This was referenced Dec 7, 2022
Merged
na--
force-pushed
the
check-for-goroutine-leaks
branch
from
1766cb7 to
2cb2c74
Compare
na--
force-pushed
the
fix-aborted-by-user-exit-codes
branch
from
e0e7e45 to
0039acb
Compare
olegbespalov
previously approved these changes
Dec 14, 2022
oleiade
previously approved these changes
Dec 16, 2022
na--
force-pushed
the
check-for-goroutine-leaks
branch
2 times, most recently
from
2a9644a to
eea76b1
Compare
na--
force-pushed
the
fix-aborted-by-user-exit-codes
branch
from
0039acb to
73f67fa
Compare
olegbespalov
approved these changes
Jan 11, 2023
oleiade
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is built on top of #2803 and tackles a small part of #2804, though definitely not the whole issue.
It was necessary to be able to split apart #1889 into a few smaller PRs and it was also necessary for #1342 in its own right.