Dont lock the event loop once a promise rejection is left unhandled #2693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when a promise is rejected but *not* handled, the event loop would end the current iteration and then let a new one start. Unfortuantely it also didn't clear the failure so the next time it will again *fail* the iteration as it still thinks a promise has been rejected without a handler. Heavily related to grafana/xk6-browser#510
mstoykov
requested review from
imiric
and removed request for
oleiade and
codebien
imiric
approved these changes
Sep 26, 2022
Yeah, I am really surprised we didn't notice it earlier. As I elude in the commit message this in practice makes the whole k6+promises workflow not work the moment you have any unhandled promise rejection. I guess that I just always write my scripts with |
oleiade
approved these changes
Sep 27, 2022
This was referenced Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when a promise is rejected but not handled, the event loop would end the current iteration and then let a new one start.
Unfortuantely it also didn't clear the failure so the next time it will again fail the iteration as it still thinks a promise has been rejected without a handler.
Heavily related to grafana/xk6-browser#510