Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error disposing browser context #558

Closed
imiric opened this issue Sep 30, 2022 · 2 comments · Fixed by #555
Closed

Error disposing browser context #558

imiric opened this issue Sep 30, 2022 · 2 comments · Fixed by #555
Assignees
Labels
bug Something isn't working next Might be eligible for the next planning (not guaranteed!)
Milestone

Comments

@imiric
Copy link
Contributor

imiric commented Sep 30, 2022

This is the issue that triggered #510, which still happens on current main (db80f94). The event loop corruption was fixed in k6 (grafana/k6#2693), but we still need to fix this trigger issue here.

It can be relatively easily reproduced on Cloud with the same script from #510. Running a test with this script with 1VU for 1h often produces this log:

Uncaught (in promise) disposing browser context: disposing browser context ID EFE761C1AE3FFA4EC51442683B3589D2: sending a message to browser: websocket: close 1006 (abnormal closure): unexpected EOF executor=constant-vus scenario=default		test_run_id: 141246
communicating with browser: websocket: close 1006 (abnormal closure): unexpected EOF category=cdp elapsed=23416 ms goroutine=1075082		test_run_id: 141246
process with PID 168213 unexpectedly ended: signal: killed category=browser elapsed=8 ms goroutine=1075068		test_run_id: 141246

The behavior is that the browser process is killed, likely because the context is cancelled, but it's not clear why that would happen during the BrowserContext.Close() call, which happens from Page.Close(), which is called before Browser.Close().

@imiric imiric added the bug Something isn't working label Sep 30, 2022
@imiric imiric added next Might be eligible for the next planning (not guaranteed!) cloud labels Oct 7, 2022
@imiric
Copy link
Contributor Author

imiric commented Oct 7, 2022

I'm increasing the priority of this, since it's the most common issue in Cloud test runs now.

@imiric imiric self-assigned this Oct 7, 2022
@imiric
Copy link
Contributor Author

imiric commented Oct 11, 2022

After #555, we no longer see this issue in the Cloud 🎉

So I'm closing this.

@imiric imiric closed this as completed Oct 11, 2022
@imiric imiric linked a pull request Oct 11, 2022 that will close this issue
@imiric imiric added this to the v0.6.0 milestone Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working next Might be eligible for the next planning (not guaranteed!)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant