Release/v0.36.0 #2340
Merged
Release/v0.36.0 #2340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
codebien
requested changes
Jan 17, 2022
yorugac
requested changes
Jan 17, 2022
mstoykov
reviewed
Jan 18, 2022
mstoykov
reviewed
Jan 18, 2022
mstoykov
reviewed
Jan 18, 2022
mstoykov
reviewed
Jan 18, 2022
oleiade
force-pushed
the
release/v0.36.0
branch
from
b268bc9 to
6b95450
Compare
na--
reviewed
Jan 18, 2022
oleiade
force-pushed
the
release/v0.36.0
branch
2 times, most recently
from
e01c0c0 to
bdf8030
Compare
na--
reviewed
Jan 20, 2022
na--
reviewed
Jan 20, 2022
na--
reviewed
Jan 20, 2022
mstoykov
reviewed
Jan 20, 2022
oleiade
force-pushed
the
release/v0.36.0
branch
2 times, most recently
from
9b064ec to
f261286
Compare
na--
reviewed
Jan 20, 2022
na--
reviewed
Jan 20, 2022
na--
reviewed
Jan 20, 2022
na--
reviewed
Jan 20, 2022
na--
reviewed
Jan 20, 2022
|
LGTM overall, these are the only nitpicks I have |
oleiade
force-pushed
the
release/v0.36.0
branch
from
0225690 to
b6ed53b
Compare
codebien
reviewed
Jan 20, 2022
There was a problem hiding this comment.
@oleiade LGTM, thanks for doing it 👏
We should link grafana/k6-docs#556 and grafana/k6-docs#559 when they will be merged
na--
reviewed
Jan 24, 2022
na--
reviewed
Jan 24, 2022
na--
reviewed
Jan 24, 2022
na--
reviewed
Jan 24, 2022
|
This PR can now be considered ready to merge. To proceed, we should ensure to |
mstoykov
reviewed
Jan 24, 2022
mstoykov
previously approved these changes
Jan 24, 2022
There was a problem hiding this comment.
LGTM apart from the ... more accurate wording of why 'optional chaining' isn't usable.
In this case I mean that if you just have var something = {"something": {}}; console.log(something?.something?.else?.third); will work as babel is not used at all. But needing babel, usually for import/export, means that you can't use it.
oleiade
force-pushed
the
release/v0.36.0
branch
from
e48d0ec to
b47ad1b
Compare
codebien
approved these changes
Jan 24, 2022
mstoykov
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds release notes for the upcoming 0.36.0 version of K6.
To compile them, I went through the commit history from 0.35.0 up to the current state of master, and looked at/experimented with most PRs that went through during this period. I might have missed things, overlooked overs, left changes so small that I didn't find them too relevant for release notes.
Please let me know if you think I've forgotten anything, explained something wrong, or didn't follow the existing template close enough. This is my first time, and I'm looking to get as much feedback as possible 🐻
Not being too familiar with SourceMaps myself, I could definitely use your help @mstoykov when it comes to describing and demonstrating the feature. Could you support me with that? 😸