Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS API for execution.test.abort #559

Merged
merged 1 commit into from
Jan 24, 2022
Merged

JS API for execution.test.abort #559

merged 1 commit into from
Jan 24, 2022

Conversation

codebien
Copy link
Contributor

Docs for test.abort() new feature

@codebien codebien self-assigned this Jan 20, 2022
@codebien codebien requested a review from imiric January 20, 2022 15:07
@codebien codebien requested a review from imiric January 21, 2022 09:44
imiric
imiric approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@imiric imiric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks a lot for picking this up! 😄

@codebien codebien requested a review from oleiade January 21, 2022 10:35
oleiade
oleiade approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@oleiade oleiade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nickel Chrome 👍🏻 Cheers for that 🦖

@codebien codebien changed the base branch from feat/archive-v0.35 to main January 24, 2022 08:45
@codebien codebien merged commit 124bf49 into main Jan 24, 2022
@codebien codebien deleted the test-abort branch January 24, 2022 08:46
@ppcano
Copy link
Collaborator

ppcano commented Jan 24, 2022

@codebien @na--

Because the default behavior of k6 is same user experience for both local and cloud users, I suggest removing:

Aborting a test is fully supported in k6 cloud, preserving the same user experience for both local and cloud users.

And, only provide the details on the exceptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@na-- na-- na-- approved these changes

@imiric imiric imiric approved these changes

@oleiade oleiade oleiade approved these changes

Assignees

@codebien codebien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@codebien @ppcano @oleiade @imiric @na--