Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade alpine base image to 3.15 #2312

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Upgrade alpine base image to 3.15 #2312

merged 1 commit into from
Dec 23, 2021

Conversation

knittl
Copy link
Contributor

@knittl knittl commented Dec 22, 2021

Closes #2310

@CLAassistant
Copy link

CLAassistant commented Dec 22, 2021

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2021

Codecov Report

Merging #2312 (c156bc5) into master (42f2e60) will increase coverage by 2.38%.
The diff coverage is 86.82%.

❗ Current head c156bc5 differs from pull request most recent head 28f598b. Consider uploading reports for the commit 28f598b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2312      +/-   ##
==========================================
+ Coverage   72.71%   75.10%   +2.38%     
==========================================
  Files         184      185       +1     
  Lines       14571    14878     +307     
==========================================
+ Hits        10596    11174     +578     
+ Misses       3333     3029     -304     
- Partials      642      675      +33     
Flag Coverage Δ
ubuntu 75.01% <86.82%> (+2.36%) ⬆️
windows 74.77% <86.82%> (+2.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/cloud.go 4.68% <0.00%> (-0.03%) ⬇️
cmd/login_cloud.go 0.00% <0.00%> (ø)
cmd/login_influxdb.go 0.00% <0.00%> (ø)
cmd/ui.go 59.27% <0.00%> (+38.65%) ⬆️
js/modules/modules.go 47.05% <ø> (-35.00%) ⬇️
lib/consts/consts.go 57.14% <ø> (+57.14%) ⬆️
lib/execution.go 92.59% <ø> (ø)
lib/execution_segment.go 92.73% <ø> (ø)
lib/execution_status_gen.go 0.00% <ø> (ø)
lib/fsext/changepathfs.go 92.95% <0.00%> (-1.33%) ⬇️
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 804203b...28f598b. Read the comment docs.

Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@na--
Copy link
Member

na-- commented Dec 23, 2021

@knittl, we can merge this as soon as you accept the new CLA. It's basically the same as the old CLA, only adjusted to reflect the acquisition by Grafana and amended so we can use the same CLA text on other repos (e.g. extensions) without contributors having to re-sign a slightly different one for every repo.

@knittl
Copy link
Contributor Author

knittl commented Dec 23, 2021

@knittl, we can merge this as soon as you accept the new CLA. It's basically the same as the old CLA, only adjusted to reflect the acquisition by Grafana and amended so we can use the same CLA text on other repos (e.g. extensions) without contributors having to re-sign a slightly different one for every repo.

I see. I wondered because I had already signed the CLA in the past. And mentioned that it still said "load impact" instead of "grafana labs". That explains that. Thanks, I have signed the new CLA!

@na-- na-- merged commit c93adb3 into grafana:master Dec 23, 2021
oleiade pushed a commit that referenced this pull request Jan 11, 2022
@yorugac yorugac added this to the v0.36.0 milestone Jan 17, 2022
@yorugac yorugac mentioned this pull request Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Docker image to use Alpine 3.15
6 participants