Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We actually need to disable sourceMaps when we compile them as well #1796

Merged
merged 2 commits into from
Jan 13, 2021
Merged

We actually need to disable sourceMaps when we compile them as well #1796

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32577d1
We actually need to disable sourceMaps when we compile them as well
mstoykov Jan 13, 2021
73e3863
Add a simple test to check sourcemaps are disabled
mstoykov Jan 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/compiler/compiler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ func (c *Compiler) Transform(src, filename string) (code string, srcmap *SourceM
func (c *Compiler) Compile(src, filename, pre, post string,
strict bool, compatMode lib.CompatibilityMode) (*goja.Program, string, error) {
code := pre + src + post
ast, err := parser.ParseFile(nil, filename, code, 0)
ast, err := parser.ParseFile(nil, filename, code, 0, parser.WithDisableSourceMaps)
if err != nil {
if compatMode == lib.CompatibilityModeExtended {
code, _, err = c.Transform(src, filename)
Expand Down