We actually need to disable sourceMaps when we compile them as well

[mstoykov]

No description provided.

[na--]

LGTM, why not update goja as well?

[mstoykov]

I wanted to also enable some tc39 tests with a new version and do it in another PR. But I already started running the tests so I can add to this one if you want to :)

[na--]

However you prefer to do it, but 👍 from me for a goja update today

[codecov-io]

Codecov Report

Merging #1796 (32577d1) into master (2904961) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1796      +/-   ##
==========================================
- Coverage   71.57%   71.53%   -0.05%     
==========================================
  Files         181      181              
  Lines       13939    13939              
==========================================
- Hits         9977     9971       -6     
- Misses       3331     3337       +6     
  Partials      631      631              

Flag	Coverage Δ
ubuntu	71.45% <100.00%> (-0.07%)	⬇️
windows	70.11% <100.00%> (-0.07%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
js/compiler/compiler.go	76.47% <100.00%> (ø)
lib/executor/vu_handle.go	93.33% <0.00%> (-1.91%)	⬇️
stats/cloud/collector.go	79.81% <0.00%> (-0.64%)	⬇️
js/runner.go	80.86% <0.00%> (-0.58%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2904961...32577d1. Read the comment docs.

[na--]

btw I have no idea how source maps work precisely, but would this change be too difficult to test?

[mstoykov]

It literally cares about a comment at the end of a source file

//# sourceMappingURL=ajv.min.js.map

[imiric]

LGTM, but this is breaking change, no? Sourcemaps were supported before?

[mstoykov]

if they at any point worked in any capacity it wasn't intentional ;)
Given the issues listed (and now fixed) in dop251/goja#235 I would expect that they never did for us