lib/netext/httpext: add support decompression of stacked compressed response #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Aug 26, 2019
cuonglm
force-pushed
the
feature/issue-1108
branch
from
b112b7f
to
b9487b5
Compare
Codecov Report
@@ Coverage Diff @@
## master #1125 +/- ##
==========================================
+ Coverage 73.37% 73.39% +0.02%
==========================================
Files 141 142 +1
Lines 10305 10323 +18
==========================================
+ Hits 7561 7577 +16
- Misses 2302 2303 +1
- Partials 442 443 +1
Continue to review full report at Codecov.
|
imiric
previously approved these changes
Aug 27, 2019
cuonglm
force-pushed
the
feature/issue-1108
branch
from
b9487b5
to
2cff513
Compare
mstoykov
requested changes
Aug 29, 2019
There was a problem hiding this comment.
Seems okay, but there are a couple of things that I would prefer if are done differently:
- the
if !assert.. is IMO an antipattern scattered everywhere in k6 that I remove when I see it and would prefer if we don't add it back ;) - the reversing of the
contentEncodingscould be done either in a way that is more easy to understand what happens if not faster (as speed in this case is probably not important) or you can just walk it with a real for backwards which seems to me like the even better solution ;)
cuonglm
force-pushed
the
feature/issue-1108
branch
from
2cff513
to
fe9bf76
Compare
cuonglm
force-pushed
the
feature/issue-1108
branch
from
fe9bf76
to
ee081f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
k6 supports compression of request bodies with multiple layered algorithms but does not handle decompression body in the same manner. This PR adds support for decompression response body with multiple layered algorithms in the same manner.
Close #1108