Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support decompression of stacked compressed responses #1108

Closed
na-- opened this issue Aug 8, 2019 · 0 comments · Fixed by #1125
Closed

Support decompression of stacked compressed responses #1108

na-- opened this issue Aug 8, 2019 · 0 comments · Fixed by #1125

Comments

@na--
Copy link
Member

na-- commented Aug 8, 2019

Currently, k6 supports compression of request bodies with multiple layered algorithms like gzip, deflate. However, it doesn't support decompressing response bodies that are compressed in a similar manner, which is arguably the more important use-case.

https://github.com/loadimpact/k6/blob/350729e053ac36c09bb26c11e4c7fb87b909f597/lib/netext/httpext/request.go#L251-L276

I've also tagged this issue as refactoring, since the compression/decompression code should probably be moved to its own file, given how it's currently interspersed very annoyingly among the rest of the request handling code...

https://github.com/loadimpact/k6/blob/350729e053ac36c09bb26c11e4c7fb87b909f597/lib/netext/httpext/request.go#L73-L91

https://github.com/loadimpact/k6/blob/350729e053ac36c09bb26c11e4c7fb87b909f597/lib/netext/httpext/request.go#L118-L138

https://github.com/loadimpact/k6/blob/350729e053ac36c09bb26c11e4c7fb87b909f597/lib/netext/httpext/request.go#L148-L225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants