Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use logrus import without alias #1110

Merged
merged 1 commit into from
Aug 13, 2019
Merged

Use logrus import without alias #1110

merged 1 commit into from
Aug 13, 2019

Conversation

cuonglm
Copy link
Contributor

@cuonglm cuonglm commented Aug 9, 2019

Also add some comments to keep linter silent.

Closes #1016

@codecov-io
Copy link

codecov-io commented Aug 9, 2019

Codecov Report

Merging #1110 into master will increase coverage by <.01%.
The diff coverage is 50.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1110      +/-   ##
==========================================
+ Coverage   73.23%   73.23%   +<.01%     
==========================================
  Files         141      141              
  Lines       10259    10260       +1     
==========================================
+ Hits         7513     7514       +1     
  Misses       2303     2303              
  Partials      443      443
Impacted Files Coverage Δ
cmd/root.go 34% <0%> (ø) ⬆️
stats/influxdb/collector.go 39.58% <0%> (ø) ⬆️
cmd/run.go 9.5% <0%> (ø) ⬆️
stats/json/collector.go 13.55% <0%> (ø) ⬆️
cmd/cloud.go 9.52% <0%> (ø) ⬆️
lib/netext/httpext/httpdebug_transport.go 75% <0%> (ø) ⬆️
js/compiler/compiler.go 79.24% <100%> (ø) ⬆️
stats/dummy/collector.go 60% <100%> (ø) ⬆️
js/console.go 95% <100%> (ø) ⬆️
stats/statsd/common/collector.go 84.53% <100%> (ø) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb7bcf8...6ade3c8. Read the comment docs.

Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! We'll merge this just after we release v0.25.1.

api/server.go Show resolved Hide resolved
cmd/root.go Outdated Show resolved Hide resolved
Also add some comments to keep linter silent.

Closes #1016
@na-- na-- merged commit e3c279f into grafana:master Aug 13, 2019
@mstoykov mstoykov added this to the v0.26.0 milestone Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use logrus without an alias
4 participants