Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use logrus without an alias #1016

Closed
na-- opened this issue May 8, 2019 · 0 comments · Fixed by #1110
Closed

Use logrus without an alias #1016

na-- opened this issue May 8, 2019 · 0 comments · Fixed by #1110

Comments

@na--
Copy link
Member

na-- commented May 8, 2019

In a lot of places in the k6 codebase, logrus is imported like this:

import (
	// ...
	log "github.com/sirupsen/logrus"
	// ...
)

As @mstoykov mentioned, importing it directly as logrus would likely be more sensible and idiomatic, to avoid confusion with the default Go stdlib log library and others.

@na-- na-- mentioned this issue May 8, 2019
39 tasks
na-- pushed a commit that referenced this issue Aug 13, 2019
Also add some comments to keep linter silent.

Closes #1016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant