Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update methods on Frame type to return Promises #47

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

allansson
Copy link

Please fill in this template.

Copy link
Member

@inancgumus inancgumus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙇 🎉

Copy link

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we will might need to revisit it though if some of the APIs change a tiny bit. E.g. textContext currently only returns string from the browser module, but we may change that to also return null when string is empty.

@inancgumus
Copy link
Member

LGTM. I think we will might need to revisit it though if some of the APIs change a tiny bit. E.g. textContext currently only returns string from the browser module, but we may change that to also return null when string is empty.

Added this as a task here grafana/xk6-browser#1302

@allansson allansson merged commit f3b2d43 into master-async-browser Jun 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants