Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Frame APIs to async #1302

Closed
7 tasks done
Tracked by #428
inancgumus opened this issue May 6, 2024 · 0 comments
Closed
7 tasks done
Tracked by #428

Migrate Frame APIs to async #1302

inancgumus opened this issue May 6, 2024 · 0 comments
Assignees
Labels
async supports async (promises) breaking PRs that need to be mentioned in the breaking changes section of the release notes

Comments

@inancgumus
Copy link
Member

inancgumus commented May 6, 2024

Tasks

  1. async mapping refactor stability
    inancgumus
  2. enhancement playwright
    inancgumus
  3. enhancement playwright
    inancgumus
  4. browser
    allansson
  5. Area: browser
    inancgumus
  6. documentation good first issue hacktoberfest
    inancgumus

What

Migrate the following APIs according to the How section in #428:

Class Method Current k6 Return PW return
Frame $ ElementHandle|null Promise<ElementHandle<SVGElement|HTMLElement>|null>
Frame $$ ElementHandle[] Promise<ElementHandle<SVGElement|HTMLElement>[]>
Frame check void Promise
Frame content string Promise
Frame dblclick void Promise
Frame dispatchEvent void Promise
Frame evaluate<R, Arg> R Promise
Frame evaluateHandle<R, Arg> JSHandle Promise<SmartHandle>
Frame fill void Promise
Frame focus void Promise
Frame frameElement ElementHandle Promise
Frame getAttribute string Promise<null|string>
Frame hover void Promise
Frame innerHTML string Promise
Frame innerText string Promise
Frame inputValue string Promise
Frame isChecked boolean Promise
Frame isDisabled boolean Promise
Frame isEditable boolean Promise
Frame isEnabled boolean Promise
Frame isHidden boolean Promise
Frame isVisible boolean Promise
Frame press void Promise
Frame selectOption string[] Promise<Array>
Frame setContent void Promise
Frame setInputFiles void Promise
Frame tap void Promise
Frame textContent string Promise<null|string>
Frame title string Promise
Frame type void Promise
Frame uncheck void Promise
Frame waitForLoadState void Promise
Frame waitForSelector ElementHandle Promise<null|ElementHandle<SVGElement|HTMLElement>>
Frame waitForTimeout void Promise

For details on the Why and How, check the overarching issue in #428.

@inancgumus inancgumus added async supports async (promises) breaking PRs that need to be mentioned in the breaking changes section of the release notes labels May 6, 2024
@inancgumus inancgumus assigned inancgumus and unassigned inancgumus May 20, 2024
@inancgumus inancgumus self-assigned this Jun 4, 2024
@inancgumus inancgumus mentioned this issue Jun 4, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
async supports async (promises) breaking PRs that need to be mentioned in the breaking changes section of the release notes
Projects
None yet
Development

No branches or pull requests

1 participant