cache typeFn in ClassMetadata

grafana · Aug 1, 2023 · 5660ef6 · 5660ef6
1 parent 1dcd969
commit 5660ef6
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/parser/chunk.go b/parser/chunk.go
@@ -152,6 +152,14 @@ func buildClasses(metadata MetadataEvent) ClassMap {
 				numConstants++
 			}
 		}
+
+		if typeFn, ok := types[class.Name]; ok {
+			class.typeFn = typeFn
+		} else {
+			class.typeFn = func() ParseResolvable {
+				return &UnsupportedType{}
+			}
+		}
 		class.numConstants = numConstants
 		classes[int(class.ID)] = class
 	}

diff --git a/parser/metadata.go b/parser/metadata.go
@@ -91,6 +91,7 @@ type ClassMetadata struct {
 	Settings     []SettingMetadata
 	Annotations  []AnnotationMetadata
 	numConstants int
+	typeFn       func() ParseResolvable
 }
 
 func (c *ClassMetadata) SetAttribute(key, value string) (err error) {

diff --git a/parser/types.go b/parser/types.go
@@ -53,12 +53,7 @@ func ParseClass(r reader.Reader, classes ClassMap, cpools PoolMap, classID int64
 	if !ok {
 		return nil, fmt.Errorf("unexpected class %d", classID)
 	}
-	var v ParseResolvable
-	if typeFn, ok := types[class.Name]; ok {
-		v = typeFn()
-	} else {
-		v = new(UnsupportedType)
-	}
+	v := class.typeFn()
 	if err := v.Parse(r, classes, cpools, class); err != nil {
 		return nil, err
 	}