batch allocate constants

grafana · Aug 1, 2023 · 1dcd969 · 1dcd969
1 parent 2aa0b33
commit 1dcd969
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 7 deletions.
diff --git a/parser/chunk.go b/parser/chunk.go
@@ -146,6 +146,13 @@ func (c *Chunk) Parse(r io.Reader, options *ChunkParseOptions) (err error) {
 func buildClasses(metadata MetadataEvent) ClassMap {
 	classes := make(map[int]ClassMetadata)
 	for _, class := range metadata.Root.Metadata.Classes {
+		var numConstants int
+		for _, field := range class.Fields {
+			if field.ConstantPool {
+				numConstants++
+			}
+		}
+		class.numConstants = numConstants
 		classes[int(class.ID)] = class
 	}
 

diff --git a/parser/metadata.go b/parser/metadata.go
@@ -83,13 +83,14 @@ func (f *FieldMetadata) AppendChild(name string) Element {
 }
 
 type ClassMetadata struct {
-	ID          int64
-	Name        string
-	SuperType   string
-	SimpleType  bool
-	Fields      []FieldMetadata
-	Settings    []SettingMetadata
-	Annotations []AnnotationMetadata
+	ID           int64
+	Name         string
+	SuperType    string
+	SimpleType   bool
+	Fields       []FieldMetadata
+	Settings     []SettingMetadata
+	Annotations  []AnnotationMetadata
+	numConstants int
 }
 
 func (c *ClassMetadata) SetAttribute(key, value string) (err error) {

diff --git a/parser/types.go b/parser/types.go
@@ -94,6 +94,9 @@ func appendConstant(r reader.Reader, constants *[]constant, name string, class i
 }
 
 func parseFields(r reader.Reader, classes ClassMap, cpools PoolMap, class ClassMetadata, constants *[]constant, resolved bool, cb func(reader.Reader, string, ParseResolvable) error) error {
+	if constants != nil && class.numConstants != 0 && !resolved {
+		*constants = make([]constant, 0, class.numConstants)
+	}
 	for _, f := range class.Fields {
 		if f.ConstantPool {
 			if constants != nil && !resolved {