Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphite: Fix for issue with alias function being moved last #17791

Merged
merged 1 commit into from
Jun 27, 2019

Conversation

torkelo
Copy link
Member

@torkelo torkelo commented Jun 27, 2019

Fixes #17099

To fix this I sadly had to remove the mostly nice feature where alias function is moved last, but looks like that is not always the right thing and knowing when it will cause issues seemed complicated so I opted to remove this feature instead.

@torkelo torkelo modified the milestones: 6.3.0, 6.3.0-beta1 Jun 27, 2019
@torkelo torkelo changed the title Graphite: Fix for issue where alias function was moved last Graphite: Fix for issue with alias function being moved last Jun 27, 2019
@torkelo torkelo merged commit 013a1ab into master Jun 27, 2019
@torkelo torkelo deleted the graphite-alias-last branch June 27, 2019 09:16
ryantxu added a commit to ryantxu/grafana that referenced this pull request Jun 27, 2019
* grafana/master:
  noImplicitAny: Lower count to about 3450 (grafana#17799)
  Graphite: Fixes issue with seriesByTag & function with variable param (grafana#17795)
  noImplicitAny: Reduce errors to 3800-ish (grafana#17781)
  Graphite: remove feature that moves alias function last (grafana#17791)
  Explore: Adds URL support for select mode (grafana#17755)
  TestData: add option to increase the number of test streams (grafana#17789)
  Usage Stats: Update known datasource plugins (grafana#17787)
  Docs: Adds section on Querying Logs for Elasticsearch (grafana#17730)
  Docs: Adds section on Querying Logs for InfluxDB (grafana#17726)
  Devenv: makes the grafana users default for saml. (grafana#17782)
  Explore: Displays only one Time column as configured in TimeZone settings (grafana#17775)
  Markdown: Replace rendering library (grafana#17686)
  ApiKeys: Fix check for UTC timezone (grafana#17776)
  Prometheus: Minor style fix (grafana#17773)
  Docs: fixed notifications table
  Auth: Allow expiration of API keys (grafana#17678)
  17278 prometheus step align utc (grafana#17477)
  Docs: Update release guide  (grafana#17759)
ryantxu added a commit to ryantxu/grafana that referenced this pull request Jun 27, 2019
…-mapping-to-field

* grafana/master: (35 commits)
  noImplicitAny: Lower count to about 3450 (grafana#17799)
  Graphite: Fixes issue with seriesByTag & function with variable param (grafana#17795)
  noImplicitAny: Reduce errors to 3800-ish (grafana#17781)
  Graphite: remove feature that moves alias function last (grafana#17791)
  Explore: Adds URL support for select mode (grafana#17755)
  TestData: add option to increase the number of test streams (grafana#17789)
  Usage Stats: Update known datasource plugins (grafana#17787)
  Docs: Adds section on Querying Logs for Elasticsearch (grafana#17730)
  Docs: Adds section on Querying Logs for InfluxDB (grafana#17726)
  Devenv: makes the grafana users default for saml. (grafana#17782)
  Explore: Displays only one Time column as configured in TimeZone settings (grafana#17775)
  Markdown: Replace rendering library (grafana#17686)
  ApiKeys: Fix check for UTC timezone (grafana#17776)
  Prometheus: Minor style fix (grafana#17773)
  Docs: fixed notifications table
  Auth: Allow expiration of API keys (grafana#17678)
  17278 prometheus step align utc (grafana#17477)
  Docs: Update release guide  (grafana#17759)
  release: update latest.json to v6.2.5 (grafana#17767)
  release: 6.2.5 changelog (grafana#17766)
  ...
markelog added a commit to markelog/grafana that referenced this pull request Jun 29, 2019
* master: (47 commits)
  Elasticsearch: Fix default max concurrent shard requests (grafana#17770)
  Explore: Fix filter by series level in logs graph (grafana#17798)
  Docs: Add v6.3 version notes and encryption format information (grafana#17825)
  Graphite: use POST for /metrics/find requests (grafana#17814)
  Dashboard: Force update after dashboard resize (grafana#17808)
  Toolkit: moved front end cli scripts to separate package and introduced very early version of plugin tools
  Explore: Uses new TimePicker from Grafana/UI (grafana#17793)
  Explore: Uses RFC3339Nano string to retrieve LogRow contexts from Loki API (grafana#17813)
  noImplicitAny: Lower count to about 3450 (grafana#17799)
  Graphite: Fixes issue with seriesByTag & function with variable param (grafana#17795)
  noImplicitAny: Reduce errors to 3800-ish (grafana#17781)
  Graphite: remove feature that moves alias function last (grafana#17791)
  Explore: Adds URL support for select mode (grafana#17755)
  TestData: add option to increase the number of test streams (grafana#17789)
  Usage Stats: Update known datasource plugins (grafana#17787)
  Docs: Adds section on Querying Logs for Elasticsearch (grafana#17730)
  Docs: Adds section on Querying Logs for InfluxDB (grafana#17726)
  Devenv: makes the grafana users default for saml. (grafana#17782)
  Explore: Displays only one Time column as configured in TimeZone settings (grafana#17775)
  Markdown: Replace rendering library (grafana#17686)
  ...
xlson added a commit to xlson/grafana that referenced this pull request Jul 1, 2019
* master: (69 commits)
  Elasticsearch: Fix default max concurrent shard requests (grafana#17770)
  Explore: Fix filter by series level in logs graph (grafana#17798)
  Docs: Add v6.3 version notes and encryption format information (grafana#17825)
  Graphite: use POST for /metrics/find requests (grafana#17814)
  Dashboard: Force update after dashboard resize (grafana#17808)
  Toolkit: moved front end cli scripts to separate package and introduced very early version of plugin tools
  Explore: Uses new TimePicker from Grafana/UI (grafana#17793)
  Explore: Uses RFC3339Nano string to retrieve LogRow contexts from Loki API (grafana#17813)
  noImplicitAny: Lower count to about 3450 (grafana#17799)
  Graphite: Fixes issue with seriesByTag & function with variable param (grafana#17795)
  noImplicitAny: Reduce errors to 3800-ish (grafana#17781)
  Graphite: remove feature that moves alias function last (grafana#17791)
  Explore: Adds URL support for select mode (grafana#17755)
  TestData: add option to increase the number of test streams (grafana#17789)
  Usage Stats: Update known datasource plugins (grafana#17787)
  Docs: Adds section on Querying Logs for Elasticsearch (grafana#17730)
  Docs: Adds section on Querying Logs for InfluxDB (grafana#17726)
  Devenv: makes the grafana users default for saml. (grafana#17782)
  Explore: Displays only one Time column as configured in TimeZone settings (grafana#17775)
  Markdown: Replace rendering library (grafana#17686)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graphite - alias family are reordered, breaking queries
1 participant