Prometheus: Take timezone into account for step alignment #17477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from moment docs, utcOffset "function returns the real offset from UTC, not the reverse offset"
method returns the UTC offset as a number of minutes
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
Jun 26, 2019
* grafana/master: Usage Stats: Update known datasource plugins (grafana#17787) Docs: Adds section on Querying Logs for Elasticsearch (grafana#17730) Docs: Adds section on Querying Logs for InfluxDB (grafana#17726) Devenv: makes the grafana users default for saml. (grafana#17782) Explore: Displays only one Time column as configured in TimeZone settings (grafana#17775) Markdown: Replace rendering library (grafana#17686) ApiKeys: Fix check for UTC timezone (grafana#17776) Prometheus: Minor style fix (grafana#17773) Docs: fixed notifications table Auth: Allow expiration of API keys (grafana#17678) 17278 prometheus step align utc (grafana#17477) Docs: Update release guide (grafana#17759)
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
Jun 26, 2019
* grafana/master: Usage Stats: Update known datasource plugins (grafana#17787) Docs: Adds section on Querying Logs for Elasticsearch (grafana#17730) Docs: Adds section on Querying Logs for InfluxDB (grafana#17726) Devenv: makes the grafana users default for saml. (grafana#17782) Explore: Displays only one Time column as configured in TimeZone settings (grafana#17775) Markdown: Replace rendering library (grafana#17686) ApiKeys: Fix check for UTC timezone (grafana#17776) Prometheus: Minor style fix (grafana#17773) Docs: fixed notifications table Auth: Allow expiration of API keys (grafana#17678) 17278 prometheus step align utc (grafana#17477) Docs: Update release guide (grafana#17759)
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
Jun 27, 2019
* grafana/master: noImplicitAny: Lower count to about 3450 (grafana#17799) Graphite: Fixes issue with seriesByTag & function with variable param (grafana#17795) noImplicitAny: Reduce errors to 3800-ish (grafana#17781) Graphite: remove feature that moves alias function last (grafana#17791) Explore: Adds URL support for select mode (grafana#17755) TestData: add option to increase the number of test streams (grafana#17789) Usage Stats: Update known datasource plugins (grafana#17787) Docs: Adds section on Querying Logs for Elasticsearch (grafana#17730) Docs: Adds section on Querying Logs for InfluxDB (grafana#17726) Devenv: makes the grafana users default for saml. (grafana#17782) Explore: Displays only one Time column as configured in TimeZone settings (grafana#17775) Markdown: Replace rendering library (grafana#17686) ApiKeys: Fix check for UTC timezone (grafana#17776) Prometheus: Minor style fix (grafana#17773) Docs: fixed notifications table Auth: Allow expiration of API keys (grafana#17678) 17278 prometheus step align utc (grafana#17477) Docs: Update release guide (grafana#17759)
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
Jun 27, 2019
…-mapping-to-field * grafana/master: (35 commits) noImplicitAny: Lower count to about 3450 (grafana#17799) Graphite: Fixes issue with seriesByTag & function with variable param (grafana#17795) noImplicitAny: Reduce errors to 3800-ish (grafana#17781) Graphite: remove feature that moves alias function last (grafana#17791) Explore: Adds URL support for select mode (grafana#17755) TestData: add option to increase the number of test streams (grafana#17789) Usage Stats: Update known datasource plugins (grafana#17787) Docs: Adds section on Querying Logs for Elasticsearch (grafana#17730) Docs: Adds section on Querying Logs for InfluxDB (grafana#17726) Devenv: makes the grafana users default for saml. (grafana#17782) Explore: Displays only one Time column as configured in TimeZone settings (grafana#17775) Markdown: Replace rendering library (grafana#17686) ApiKeys: Fix check for UTC timezone (grafana#17776) Prometheus: Minor style fix (grafana#17773) Docs: fixed notifications table Auth: Allow expiration of API keys (grafana#17678) 17278 prometheus step align utc (grafana#17477) Docs: Update release guide (grafana#17759) release: update latest.json to v6.2.5 (grafana#17767) release: 6.2.5 changelog (grafana#17766) ...
marefr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Partially fixes an issue with prometheus query step alignment. Step alignment was done on UTC epoch. It should take timezone into account.
Which issue(s) this PR fixes: partially attempts to fix 17278. I have another branch that isn't ready but would be nice to have some consideration of.
Fixes #
Special notes for your reviewer: I have little idea what I am doing so feel free to criticize. Thank you for everything.