Prometheus: Change alignment of range queries to end before now and not in future #16110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- future aligment cause issues with rate charts and the display of last values - this change modifies the aligment to use the last available aligned end date and no longer possibly requests data from the future
make build-docker-fullif you want to try this without installing all deps The gap is small enough that I dont care. LGTM 👍 master this pr
|
|
Thanks 1M! |
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
Mar 21, 2019
* grafana/master: (56 commits) another change that didn't come with earlier commit change that didn't come with in last commit reversed dashboard-padding Update CloudWatch metrics/dimension list (grafana#16102) brought back dashboard-padding and panel-padding variables, made dashboard-padding more specific fix(prometheus): Change aligment of range queries (grafana#16110) Minor refactoring of testdata query order PR grafana#16122 cleaner version maintain query order Update PLUGIN_DEV.md Merge with master, and updated logo and name more fixes to snapshot more fixes to snapshot removed empty space in snapshot fixed snapshot for test removed dashboard variables, removed headings-font-family variable, created theme variables for links and z-index, removed unused class in _panel_editor and _dashboard Tooltip: show percent instead of value Right tooltip position Add "No data points" message Improve tooltip look ...
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
Mar 21, 2019
* grafana/master: (56 commits) another change that didn't come with earlier commit change that didn't come with in last commit reversed dashboard-padding Update CloudWatch metrics/dimension list (grafana#16102) brought back dashboard-padding and panel-padding variables, made dashboard-padding more specific fix(prometheus): Change aligment of range queries (grafana#16110) Minor refactoring of testdata query order PR grafana#16122 cleaner version maintain query order Update PLUGIN_DEV.md Merge with master, and updated logo and name more fixes to snapshot more fixes to snapshot removed empty space in snapshot fixed snapshot for test removed dashboard variables, removed headings-font-family variable, created theme variables for links and z-index, removed unused class in _panel_editor and _dashboard Tooltip: show percent instead of value Right tooltip position Add "No data points" message Improve tooltip look ...
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
Mar 21, 2019
* grafana/master: (107 commits) another change that didn't come with earlier commit change that didn't come with in last commit reversed dashboard-padding Update CloudWatch metrics/dimension list (grafana#16102) brought back dashboard-padding and panel-padding variables, made dashboard-padding more specific fix(prometheus): Change aligment of range queries (grafana#16110) Minor refactoring of testdata query order PR grafana#16122 cleaner version maintain query order Update PLUGIN_DEV.md Merge with master, and updated logo and name update table data model fix(graphite): nonNegativeDerivative argument hidden if 0, fixes grafana#12488 Correct table names of sql storage for remotecache more fixes to snapshot more fixes to snapshot Fixed gofmt issue in PR grafana#16093 removed empty space in snapshot fix: Update snapshot related to new jest version fixed snapshot for test ...
torkelo
changed the title
|
I have deployed it. It is cool! |
Why does my grafana still showing future data? grafana:v7.1.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
values
end date and no longer possibly requests data from the future
Fixes #15385
Fixes #13419 (although if the step is too big and the data too recent, this can't be made to work)