Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] nonNegativeDerivative argument hidden if 0 #12488

Closed
yuribit opened this issue Jul 2, 2018 · 1 comment · Fixed by #16105
Closed

[Bug] nonNegativeDerivative argument hidden if 0 #12488

yuribit opened this issue Jul 2, 2018 · 1 comment · Fixed by #16105
Assignees
@torkelo
Labels
area/datasource datasource/Graphite type/bug
Milestone
6.1.0-beta1

Comments

@yuribit
Copy link

yuribit commented Jul 2, 2018 •
edited
Loading

What Grafana version are you using?

5.1.2

What datasource are you using?

Graphite 1.1.2

What did you do?

  1. Create a Graph panel to display the graphite metric A
  2. Apply the "nonNegativeDerivative" function passing 0 as argument (max_value).
    It should look like nonNegativeDerivative(A, 0)
  3. Click on "Toggle Edit Mode"

What was the expected result?

screen shot 2018-07-02 at 11 40 45 am

What happened instead?

screen shot 2018-07-02 at 11 40 20 am

nonNegativeDerivative(#A, 0) != nonNegativeDerivative(#A)
@yuribit yuribit changed the title [Bug] [Bug] nonNegativeDerivative argument hidden if 0 Jul 2, 2018
@marefr
Copy link
Contributor

marefr commented Jul 3, 2018 •
edited
Loading

Confirmed bug in Grafana 5.3.0-pre (latest) as well.

Please note that it's a UI bug. Even if the zero isn't displayed after you've toggled edit mode, if you click on the nonNegativeDerivative function to edit you'll see that the zero is there. Also if you inspect the query using query inspector or chrome dev tools network tab you'll see that the zero is still sent to the graphite server in query.

@marefr marefr added this to the 5.3 milestone Jul 3, 2018
@marefr marefr modified the milestones: 5.3, 5.4 Aug 13, 2018
@bergquist bergquist modified the milestones: 5.4-beta1, 5.5 Nov 12, 2018
@torkelo torkelo removed this from the 5.5 milestone Jan 7, 2019
@torkelo torkelo added this to the 6.1 milestone Feb 19, 2019
@torkelo torkelo self-assigned this Mar 20, 2019
@torkelo torkelo mentioned this issue Mar 20, 2019
Merged
torkelo added a commit that referenced this issue Mar 20, 2019
@torkelo
fix(graphite): nonNegativeDerivative argument hidden if 0, fixes #12488
78d9331
ryantxu added a commit to ryantxu/grafana that referenced this issue Mar 20, 2019
@ryantxu
Merge remote-tracking branch 'grafana/master' into big-value-component
899d54c 
* grafana/master:
  update table data model
  fix(graphite): nonNegativeDerivative argument hidden if 0, fixes grafana#12488
  flot pairs
ryantxu added a commit to ryantxu/grafana that referenced this issue Mar 21, 2019
@ryantxu
Merge remote-tracking branch 'grafana/master' into table-reducer
f8094a6 
* grafana/master: (107 commits)
  another change that didn't come with earlier commit
  change that didn't come with in last commit
  reversed dashboard-padding
  Update CloudWatch metrics/dimension list (grafana#16102)
  brought back dashboard-padding and panel-padding variables, made dashboard-padding more specific
  fix(prometheus): Change aligment of range queries (grafana#16110)
  Minor refactoring of testdata query order PR grafana#16122
  cleaner version
  maintain query order
  Update PLUGIN_DEV.md
  Merge with master, and updated logo and name
  update table data model
  fix(graphite): nonNegativeDerivative argument hidden if 0, fixes grafana#12488
  Correct table names of sql storage for remotecache
  more fixes to snapshot
  more fixes to snapshot
  Fixed gofmt issue in PR grafana#16093
  removed empty space in snapshot
  fix: Update snapshot related to new jest version
  fixed snapshot for test
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@torkelo torkelo

Labels
area/datasource datasource/Graphite type/bug
Projects
None yet
Milestone
6.1.0-beta1
Development

Successfully merging a pull request may close this issue.

Graphite: fixed nonNegativeDerivative argument hidden if 0 grafana/grafana
4 participants
@torkelo @bergquist @yuribit @marefr